Use static string with fail!() and remove fail!(fmt!()) #6357
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Oops. Fixed a failing test case after @graydon had already r+'d, didn't know that github throws away everything on a changed commit :-( Only change from the previous one is in |
|
Delightful cleanups! 🐤 |
|
Rebased due to merge conflicts |
|
Will currently cause conflicts with PRs in bors' pending queue... |
|
@dotdash sorry about that! I've given it a high priority so it'll get built next, assuming it survives that first pull... |
|
@dotdash :( Well it looks like the next two pulls in the queue wouldn't conflict with this, if you can manage to update this branch in the next hour or so I'll run it through again. |
fail!() used to require owned strings but can handle static strings now. Also, it can pass its arguments to fmt!() on its own, no need for the caller to call fmt!() itself.
bors
added a commit
that referenced
this pull request
May 14, 2013
fail!() used to require owned strings but can handle static strings now. Also, it can pass its arguments to fmt!() on its own, no need for the caller to call fmt!() itself.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fail!() used to require owned strings but can handle static strings
now. Also, it can pass its arguments to fmt!() on its own, no need for
the caller to call fmt!() itself.